Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused resources #4

Merged
merged 5 commits into from
Oct 5, 2021
Merged

Remove unused resources #4

merged 5 commits into from
Oct 5, 2021

Conversation

antonioT90
Copy link
Contributor

@antonioT90 antonioT90 commented Oct 5, 2021

List of changes

Removed mocks and api_config
Aligned to terraform-template updates
setted external domain

Motivation and context

Type of changes

  • Add new resources
  • Update configuration to existing resources
  • Remove existing resources

Does this introduce a change to production resources with possible user impact?

  • Yes, users may be impacted applying this change
  • No

Does this introduce an unwanted change on infrastructure? Check terraform plan execution result

  • Yes
  • No

Other information


If PR is partially applied, why? (reserved to mantainers)

@antonioT90 antonioT90 requested review from a team and pasqualedevita October 5, 2021 12:10
Copy link
Member

@pasqualedevita pasqualedevita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only few changes :)

Co-authored-by: Pasquale De Vita <[email protected]>
@antonioT90 antonioT90 merged commit 8d4a483 into main Oct 5, 2021
@antonioT90 antonioT90 deleted the remove-unused-resources branch October 5, 2021 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants